Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sync_period configurable and add Dockerfiles #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make sync_period configurable and add Dockerfiles #15

wants to merge 2 commits into from

Conversation

zhucebuliaolongchuan
Copy link

  • Add Dockerfile - Dockerfile.cloud-deployment that used by current cloud deployment
  • Rename two Dockerfiles to distinguish them - one for cloud deployment, and the other one for docker compose showcase
  • Make sync_period configurable by updating startup_kube.sh for Dockerfile.cloud-deployment to use
  • Update dependencies to make sure Dockerfile.cloud-deployment could be built successfully

@zhucebuliaolongchuan
Copy link
Author

@c1728p9 this is the same PR as #14. The reason why I created a new one is because the CI might not happy with my branch name but it doesn't seem to be like this. You could simply approve this if it still looks good to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c1728p9 c1728p9 c1728p9 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhucebuliaolongchuan @c1728p9